-
Notifications
You must be signed in to change notification settings - Fork 293
Derive serde::Serialize for GetTransactionResultDetail et al #250
Derive serde::Serialize for GetTransactionResultDetail et al #250
Conversation
3aa5b67 to
1cac120
Compare
|
Just added |
|
@casey Can you update this PR to include ordinals#5 ? |
|
Looks clean and simple to me 🚀 |
|
Not sure why CI didn't run on this -- but |
af28628 to
1cac120
Compare
1cac120 to
d85da1d
Compare
|
We ran into a few other types that we needed Serialize/Deserialize implementations for. I thought that it probably isn't a good idea to add implementations piecemeal, and that all the API types should support Serialize and Deserialize if possible. I derived Serialize and Deserialize for all API types, skipping a couple where a field didn't support serialize or deserialize. |
tcharding
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK d85da1d
|
Nice, thank you for the merge! |
We're implementing
get_transactionfor our dummy Bitcoin RPC server, and we need to construct and return aGetTransactionResultDetail, butGetTransactionResultDetaildoesn't implementSerialize. This PR derivesSerializeforGetTransactionResultDetail, as well as the types it contains.