Alternative implementation for maxfeerate and maxburnamount
#377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onchainguy-btc
changed the title
maxfeerate and maxburnamount
|
Heads up that this repo appears unmaintained -- we have another project https://github.com/rust-bitcoin/rust-bitcoind-json-rpc/ we are working on to replace it. So I don't think either PR here is going to move forward anytime soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this already done but didn't submit the PR yet. Then saw that @casey submitted a PR.
Thought introducing a new function makes it a bit easier for people to upgrade but I'm also a rust noob 🤷 So if you prefer #376 then lets throw this away 🥲