Skip to content

Allow collapsing sidebar, make sidebar have minimum size #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow collapsing sidebar, make sidebar have minimum size #236

wants to merge 1 commit into from

Conversation

eira-fransham
Copy link
Contributor

@eira-fransham eira-fransham commented Jun 28, 2018 •
edited
Loading

I considered making a generic Collapsible component but I didn't think that it was worth the effort seeing as it will probably go unused apart from in the sidebar.

nrc
nrc reviewed Jun 30, 2018
View reviewed changes
Copy link
Contributor

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Could you rebase please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nrc nrc nrc left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eira-fransham @nrc