Skip to content

Conversation

korken89
Copy link
Contributor

No description provided.

@korken89
Copy link
Contributor Author

Ops, broke something. Looking into it.

@korken89 korken89 marked this pull request as draft September 20, 2025 06:58
@korken89
Copy link
Contributor Author

I gave their CHANGELOG a look and also went through their example - and could not really find anything that's changed which would make interrupts stop working.

I'll look a bit more tonight, but if someone sees the obvious error feel free to ping me. :)

@jonathanpallant
Copy link
Contributor

jonathanpallant commented Sep 20, 2025

uuuugh why isn't 0.7 tagged in the repo

I will go complain on their Discord

@jonathanpallant
Copy link
Contributor

  • test.sh MISMATCH: Binary gic-map for target armv8r-none-eabihf mismatched
  • test.sh MISMATCH: Binary gic-static-section-irq for target armv8r-none-eabihf mismatched
  • test.sh MISMATCH: Binary gic-unified-irq for target armv8r-none-eabihf mismatched

@jonathanpallant
Copy link
Contributor

jonathanpallant commented Sep 20, 2025

These tests pass locally for me, using QEMU 10.1.

No, due to #59 I wasn't running the failing tests. Not a QEMU issue.

@jonathanpallant
Copy link
Contributor

jonathanpallant commented Sep 20, 2025

I was able to replicate by using QEMU 9 on x86-64 (in a VM, on my Mac).

Edit: and locally on my Mac using QEMU 10.

@jonathanpallant
Copy link
Contributor

The examples need this code adding, to replace some set-up that 0.6.1 did and 0.7.0 does not:

    gic.distributor().configure_default_settings();
    gic.distributor().enable_affinity_routing_non_secure(true);
    gic.distributor().enable_group1_non_secure(true);

However, this is impossible due to a typo in the definition of the fn distributor() function in arm-gic.

They wrote:

pub fn distributor(&mut self) -> &'a mut GicDistributor<'_> {

They meant:

pub fn distributor(&mut self) -> &mut GicDistributor<'a> {

Because 'a is the lifetime annotation for the references inside the GicDistibutor structure.

@korken89
Copy link
Contributor Author

When the new arm-gic is released I'll squash my cleanup stuff and provide a singular commit.

@korken89 korken89 marked this pull request as ready for review September 29, 2025 16:39
@korken89
Copy link
Contributor Author

Alright, arm-gic 0.7.1 is released and this should now be ready! 🎉

@jonathanpallant jonathanpallant added this pull request to the merge queue Sep 30, 2025
Merged via the queue into rust-embedded:main with commit cfa09e1 Sep 30, 2025
57 checks passed
@korken89 korken89 deleted the update-arm-gic branch September 30, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants