Closed
Conversation
BartMassey
added a commit
to rust-embedded/discovery-mb2
that referenced
this pull request
Nov 8, 2024
Member
|
Thanks for the suggestion! Not sure git-ignoring an editor-specific dotfile is a great idea at all, actually: once we go down that road there's a lot of things we could do, but it probably belongs in folks' global gitignore instead. I'm going to remove that line in https://github.com/rust-embedded/discovery-mb2 . Probably won't touch this, as we're trying to move over there soon. Again, thanks. |
Author
|
Yeah, that makes a lot of sense. I'll close this not to clutter up this repo. |
BartMassey
added a commit
to rust-embedded/discovery-mb2
that referenced
this pull request
Nov 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny QoL PR.
There's no real reason (that I can see) to only ignore
.ideain the repo root. If you only have a Microbit for example, you're going to work in the appropriate subdirectory and any.ideadirectory that gets created is just clutter.