remove eh0 feature from default features#122
Merged
dbrgn merged 1 commit intorust-embedded:mainfrom Sep 13, 2024
Merged
Conversation
This was referenced Sep 9, 2024
Closed
Contributor
|
sorry i hadn't got to this yet. |
Collaborator
|
I agree with this change 🙂 Let's wait until #124 is merged. |
Collaborator
|
@rursprung merged, you can rebase now! |
`embedded-hal` v1.0 came out in january 2024, going forward new code should use this. accordingly, `eh0` support should no longer be part of the default features to reduce the amount of dependencies being pulled in. existing code will likely still use it, thus consumers will have to explicitly enable the feature when upgrading.
rursprung
force-pushed
the
remove-eh0-from-default-features
branch
from
a3ee956 to
deb84ee
Compare
|
FYI, the README still states that the |
Member
Thanks! Fixed in #130 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
embedded-halv1.0 came out in january 2024, going forward new code should use this. accordingly,eh0support should no longer be part of the default features to reduce the amount of dependencies being pulled in.existing code will likely still use it, thus consumers will have to explicitly enable the feature when upgrading.
CC @tommy-gilligan (you suggested the same as part of your larger draft) & @eldruin (i noticed it due to your comment here: rust-embedded-community/tb6612fng-rs#51 (review))