Skip to content

Conversation

chrysn
Copy link
Contributor

@chrysn chrysn commented Aug 12, 2025

Contributes-To: #566

This is a Draft PR until

  • I've satisfied all the interdependencies between other crates from the same workspace (as they have both version and path, they have to change their dependency version in the same PR),
  • I've updated the date to my best guess of the release, and
  • I think we won't wait more for any new changes (embedded-io: API stability and 1.0.0 release #566 has been open for a while, so that shouldn't be too long).

@chrysn chrysn marked this pull request as ready for review August 14, 2025 09:16
@chrysn chrysn requested a review from a team as a code owner August 14, 2025 09:16
@chrysn
Copy link
Contributor Author

chrysn commented Aug 14, 2025

I think this is ready for review; having been announced on the Tuesday WG meeting is probably as much exposure for any more "let's get that in"s as this gets before doing an actual release.

@Oakchris1955
Copy link
Contributor

In my opinion, #648 should be resolved before releasing v0.7

@chrysn
Copy link
Contributor Author

chrysn commented Sep 6, 2025 via email

ColinFinck added a commit to ColinFinck/embedded-hal that referenced this pull request Sep 23, 2025
As a preparation for the (hopefully) upcoming release. Looking forward to rust-embedded#679.
@ColinFinck
Copy link
Contributor

@chrysn What's the status on this? Any blockers left for a 0.7 release?
I've already updated the README in #706 to reflect some of the changes to embedded-io.

@chrysn
Copy link
Contributor Author

chrysn commented Sep 24, 2025

I don't think there's anything other than someone from the team saying "Yes" missing. (I can rebase this any time, but there's probably no point to that until there's confirmation, given there should be a date to include).

@jamesmunns
Copy link
Member

Ping @rust-embedded/hal

@mkroening
Copy link

The following PRs would be very useful to us:

Just to make sure they don't go unnoticed. :)

@chrysn
Copy link
Contributor Author

chrysn commented Sep 24, 2025

#696 is about the async counterpart that isn't going for a last-call-before 1.0 (and is unaffected by the embedded-io release). Reading the issue, I think what async does now is better (and maybe we should provide .flush() here), but also, I don't care a lot (like, I'd like to change it if it's uncontroversial, but not start a week-long discussion).

#697 is not breaking, so it could go into a 0.7.1 as well – nonetheless, looking into it.

therealprof
therealprof previously approved these changes Sep 24, 2025
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

io-async and io-adapters are updated to keep the path and version in
sync.

Contributes-To: rust-embedded#566
@chrysn
Copy link
Contributor Author

chrysn commented Sep 26, 2025

Thanks. Date is adjusted to today, hope this holds until the button is pressed :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants