Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify lints #1478

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Simplify lints #1478

merged 2 commits into from
Apr 11, 2024

Conversation

janhohenheim
Copy link
Collaborator

@janhohenheim janhohenheim commented Apr 10, 2024

Fixes #639
Additionally removes lint for ul list style.

I'm relaxing our lints massively because I want to streamline the process for potential contributors by reducing as much friction as possible. If the current editors since the revival find the lints too relaxed, I'm very open to changing them in the next release cycle.

@janhohenheim janhohenheim removed their assignment Apr 10, 2024
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very much in favour of this - it's the style of the output we care about, not so much the Markdown itself. As long as the submission renders nicely and is easily reviewable/editable, I don't think there's much value in chasing people over line lengths or list styles tbh.

@janhohenheim janhohenheim merged commit d9d3e21 into source Apr 11, 2024
1 check passed
@janhohenheim janhohenheim deleted the lints branch April 11, 2024 12:38
@Keavon
Copy link
Contributor

Keavon commented Apr 11, 2024

I'll just drop a comment to mention that any line length limit (like 160 now) still means contributors can't just type text and will still have to submit a PR, learn that it fails CI, investigate, make changes to break the text across lines, and re-submit the PR at least once more. Doubling the limit makes it slightly less annoying but doesn't fix that frustrating and (for new contributors) surprising limitation. Make of that what you will, but that's just an explanation of my view.

@janhohenheim
Copy link
Collaborator Author

@Keavon good point. I decided to leave in a limit as a compromise since #639 shows that editors generally really want a character limit. If I see many contributors running into this, I'll open a PR removing the limit altogether.

@janhohenheim
Copy link
Collaborator Author

janhohenheim commented Apr 11, 2024

Got a follow-up at #1480
@17cupsofcoffee could you check it out when you have time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line Length Lint
3 participants