-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add N52 update for Untitled Pixel Wizards Game #1529
Merged
janhohenheim
merged 5 commits into
rust-gamedev:source
from
caspark:caspark-n052-update
Jun 29, 2024
Merged
Add N52 update for Untitled Pixel Wizards Game #1529
janhohenheim
merged 5 commits into
rust-gamedev:source
from
caspark:caspark-n052-update
Jun 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspark
commented
Jun 27, 2024
caspark
commented
Jun 27, 2024
caspark
commented
Jun 27, 2024
caspark
commented
Jun 27, 2024
Shortcode is apparently necessary because raw HTML tags are not allowed - and that fixes the line length violation too. The double commenting in the shortcode of '<!-- {#' is necessary to ensure that the comment is syntax-highlighted nicely and that Tera does not try to interpret the example snippet as a macro invocation.
caspark
force-pushed
the
caspark-n052-update
branch
from
June 27, 2024 08:08
ef98066
to
41c19ef
Compare
Update looks great, thanks for contributing! I like the ragdolls :) |
janhohenheim
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for Untitled Pixel Wizards Game.
Includes both gif and mp4 versions of the "feature image" - per our conversation last month, you can see that in this case the mp4 is a third of the size despite being twice the resolution.
I've added a tiny bit of CSS to make sure that the "caption" gets styled correctly under the video.
Here's how it looks:
Anyway, we probably don't want both gif and mp4 files bloating the repo so I'm assuming you will (or you will ask me to) delete either the gif or the mp4, depending on how the "emailed version of the newsletter" thing is progressing.
Part of #1523