feat: impl PeekingNext for std::collections::* #1073
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1073 +/- ##
==========================================
- Coverage 94.38% 93.75% -0.64%
==========================================
Files 48 50 +2
Lines 6665 6327 -338
==========================================
- Hits 6291 5932 -359
- Misses 374 395 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Hashmap is only available under |
phimuemue
requested changes
Nov 4, 2025
phimuemue
requested changes
Nov 4, 2025
src/peeking_take_while.rs
Outdated
| peeking_next_by_clone! { ['a, T] alloc::collections::linked_list::Iter<'a, T> } | ||
| #[cfg(feature = "use_alloc")] | ||
| peeking_next_by_clone! { ['a, T] alloc::collections::vec_deque::Iter<'a, T> } | ||
| const _: () = { |
Member
There was a problem hiding this comment.
Please replace then const _ with repeated gates.
If we start adopting this pattern, we should do it consistently and not arbitrarily only here.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
phimuemue
requested changes
Nov 4, 2025
Member
phimuemue
left a comment
phimuemue
left a comment
There was a problem hiding this comment.
Can you fix CI and squash the commits?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.