Add TeamDirectory and load people/teams names #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reddevilmidzy
force-pushed
the
people-and-team
branch
2 times, most recently
from
4f95efe to
ed57309
Compare
Member
Author
|
@Kobzol I’d appreciate it if you could take a look when you have time. |
Kobzol
reviewed
Jan 29, 2026
Member
Kobzol
left a comment
Kobzol
left a comment
There was a problem hiding this comment.
Thank you! Left one nit about lowercasing, but other than that looks great.
reddevilmidzy
force-pushed
the
people-and-team
branch
from
2c08e82 to
4f3fba0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to: #675
The logic that previously checked with r+ permission has been changed to a method that checks by retrieving people and team names from the team API.
Fixes: #191