- 
                Notifications
    You must be signed in to change notification settings 
- Fork 216
Add custom docker image support #1193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            devsnek
  wants to merge
  4
  commits into
  rust-lang:master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
devsnek:custom-docker-images
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Changes from all commits
      Commits
    
    
  File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
      
      Oops, something went wrong.
      
    
  
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -106,11 +106,15 @@ impl RustwideBuilder { | |
| self.skip_build_if_exists = should; | ||
| } | ||
|  | ||
| fn prepare_sandbox(&self, limits: &Limits) -> SandboxBuilder { | ||
| SandboxBuilder::new() | ||
| fn prepare_sandbox(&self, metadata: &Metadata, limits: &Limits) -> Result<SandboxBuilder> { | ||
| let mut builder = SandboxBuilder::new() | ||
| .cpu_limit(self.config.build_cpu_limit.map(|limit| limit as f32)) | ||
| .memory_limit(Some(limits.memory())) | ||
| .enable_networking(limits.networking()) | ||
| .enable_networking(limits.networking()); | ||
| if let Some(image) = metadata.docker_image() { | ||
| builder = builder.image(SandboxImage::remote(&image)?) | ||
| } | ||
| Ok(builder) | ||
| } | ||
|  | ||
| pub fn update_toolchain(&mut self) -> Result<()> { | ||
|  | @@ -208,11 +212,15 @@ impl RustwideBuilder { | |
| let krate = Crate::crates_io(DUMMY_CRATE_NAME, DUMMY_CRATE_VERSION); | ||
| krate.fetch(&self.workspace)?; | ||
|  | ||
| let metadata = Metadata::from_crate_root(&build_dir.get_source_dir(&krate)?)?; | ||
|  | ||
| build_dir | ||
| .build(&self.toolchain, &krate, self.prepare_sandbox(&limits)) | ||
| .build( | ||
| &self.toolchain, | ||
| &krate, | ||
| self.prepare_sandbox(&metadata, &limits)?, | ||
| ) | ||
| .run(|build| { | ||
| let metadata = Metadata::from_crate_root(&build.host_source_dir())?; | ||
|  | ||
| let res = self.execute_build(HOST_TARGET, true, build, &limits, &metadata)?; | ||
| if !res.result.successful { | ||
| failure::bail!("failed to build dummy crate for {}", self.rustc_version); | ||
|  | @@ -322,14 +330,18 @@ impl RustwideBuilder { | |
|  | ||
| let local_storage = tempfile::Builder::new().prefix("docsrs-docs").tempdir()?; | ||
|  | ||
| let metadata = Metadata::from_crate_root(&build_dir.get_source_dir(&krate)?)?; | ||
| let res = build_dir | ||
| .build(&self.toolchain, &krate, self.prepare_sandbox(&limits)) | ||
| .build( | ||
| &self.toolchain, | ||
| &krate, | ||
| self.prepare_sandbox(&metadata, &limits)?, | ||
| ) | ||
| .run(|build| { | ||
| use docsrs_metadata::BuildTargets; | ||
|  | ||
| let mut has_docs = false; | ||
| let mut successful_targets = Vec::new(); | ||
| let metadata = Metadata::from_crate_root(&build.host_source_dir())?; | ||
| let BuildTargets { | ||
| default_target, | ||
| other_targets, | ||
|  | @@ -424,6 +436,11 @@ impl RustwideBuilder { | |
| build_dir.purge()?; | ||
| krate.purge_from_cache(&self.workspace)?; | ||
| local_storage.close()?; | ||
| if let Some(image) = metadata.docker_image() { | ||
| std::process::Command::new("docker") | ||
| There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd move this to rustwide's  | ||
| .args(&["image", "rm", image]) | ||
| .status()?; | ||
| } | ||
| Ok(res.result.successful) | ||
| } | ||
|  | ||
|  | ||
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise someone could DOS the queue by publishing a bunch of crates with crates-build-env set.
Actually, I guess they could do that anyway, crates-build-env isn't special ... we just use it by default, so it will be redownloaded. But if you publish a bunch of crates in a row with the same image, it will redownload the image for each crate.
@pietroalbini what do you think, is that a threat model worth worrying about? It won't break the server, it will just make builds really slow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some other ways to break this: