Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: futures-util::StreamExt: cite map and then in docs #2756

Merged

Conversation

marcospb19
Copy link
Contributor

No description provided.

@taiki-e
Copy link
Member

taiki-e commented Jun 28, 2023

Thanks for the PR.

I don't think "synchronous alternative"/"asynchronous alternative" is a very clear explanation.

How about something like "if you want to use a closure that returns a value instead of a future"?

@marcospb19 marcospb19 force-pushed the docs-stream-ext-mention-map-and-then branch from cc0e665 to fef4146 Compare June 28, 2023 06:35
Comment on lines +340 to +341
/// See [`StreamExt::then`](Self::then) if you want to use a closure that
/// returns a future instead of a value.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I force-pushed accordingly, WDYT?

@marcospb19
Copy link
Contributor Author

marcospb19 commented Jun 28, 2023

I think CI is failing for unrelated reasons.

@taiki-e taiki-e added docs A-stream Area: futures::stream 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Jul 19, 2023
@taiki-e taiki-e merged commit 28cb6a2 into rust-lang:master Jul 19, 2023
@marcospb19 marcospb19 deleted the docs-stream-ext-mention-map-and-then branch July 20, 2023 18:37
@taiki-e taiki-e mentioned this pull request Oct 26, 2023
@taiki-e taiki-e added 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants