Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rtems cfg-ed import with the others #3932

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tgross35
Copy link
Contributor

Clean up code added in #3866

@rustbot
Copy link
Collaborator

rustbot commented Sep 17, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35
Copy link
Contributor Author

@thesummer just noticed this when starting a backport, is there any reason it was in a separate cfg block in #3866?

@thesummer
Copy link
Contributor

thesummer commented Sep 17, 2024

@thesummer just noticed this when starting a backport, is there any reason it was in a separate cfg block in #3866?

@tgross35 Yes, IIRC it is because I also need the arm config block enabled. If it is in the general else-if chain it will be only one of the two.
Atm one could include the arm module also in the rtems branch. However, this might need to be changed if other RTEMS targets are added (but we can also change it when the time comes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants