apple: Add missing TIOCGETA/TIOCSETA constants #4736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add TIOCGETA (0x40487413) for getting termios state - Add TIOCSETA (0x80487414) for setting termios state immediately - Add TIOCSETAW (0x80487415) for draining output then setting - Add TIOCSETAF (0x80487416) for draining output, flushing input, then setting These constants are present in macOS system headers but were missing from the libc crate. Fixes issue rust-lang#4735.
rustbot
added
O-macos
O-unix
stable-nominated
mmastrac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TIOCGETA/TIOCSETAare missing in Apple's libc implementation in this crate, but are present in the various OS headers. These ioctls are present in other BSD-like platforms and have the same functionality.This PR adds:
0x40487413) for getting termios state0x80487414) for setting termios state immediately0x80487415) for draining output then setting0x80487416) for draining output, flushing input, then settingFixes issue #4735.
Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated