Skip to content

Conversation

@KaiTomotake
Copy link

@KaiTomotake KaiTomotake commented Jan 17, 2026

Description

Add the environ variable to unix/mod.rs.

Sources

https://github.com/bminor/glibc/blob/872cc459a9ec2a082cf1c292246708c7327d55e9/posix/environ.c#L9

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

Fixes #2520

@KaiTomotake
Copy link
Author

FreeBSD CI failed due to crates.io SSL certificate verification error.
This appears to be an infrastructure issue unrelated to this PR.

Add the environ variable to unix/mod.rs.

add aarch64_macos_15_5_or_newer cfg
@rustbot
Copy link
Collaborator

rustbot commented Jan 19, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@JohnTitor
Copy link
Member

Does macOS have it in the headers? Any source?

@KaiTomotake
Copy link
Author

I investigated this further, but I wasn’t able to confirm sufficiently reliable primary sources regarding environ on my own. Given this uncertainty, I believe it would be risky to add it to libc as-is, so I plan to close this PR for now. If clearer evidence or assumptions can be established in the future, I would be happy to revisit it.
I am truly sorry.

@KaiTomotake KaiTomotake deleted the add-environ-variable branch January 19, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "environ"

3 participants