Skip to content

Commit

Permalink
Auto merge of #132173 - veluca93:abi_checks, r=RalfJung,compiler-errors
Browse files Browse the repository at this point in the history
Emit warning when calling/declaring functions with unavailable vectors.

On some architectures, vector types may have a different ABI depending on whether the relevant target features are enabled. (The ABI when the feature is disabled is often not specified, but LLVM implements some de-facto ABI.)

As discussed in rust-lang/lang-team#235, this turns out to very easily lead to unsound code.

This commit makes it a post-monomorphization future-incompat warning to declare or call functions using those vector types in a context in which the corresponding target features are disabled, if using an ABI for which the difference is relevant. This ensures that these functions are always called with a consistent ABI.

See the [nomination comment](rust-lang/rust#127731 (comment)) for more discussion.

Part of #116558

r? RalfJung
  • Loading branch information
bors committed Nov 10, 2024
2 parents c3f9921 + eb10ada commit 0df35fc
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 0df35fc

Please sign in to comment.