bump ui_test to 0.22 #3279
Closed
bump ui_test to 0.22 #3279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
Jan 25, 2024
Comment on lines
+95
to
+96
| // keep in sync with `./miri run` | ||
| config.comment_defaults.base().edition = Some(Spanned::dummy("2021".into())).into(); |
There was a problem hiding this comment.
It's a bit unclear what should be kept in sync.
Suggested change
| // keep in sync with `./miri run` | |
| config.comment_defaults.base().edition = Some(Spanned::dummy("2021".into())).into(); | |
| let edition = "2021"; // keep in sync with `./miri run` | |
| config.comment_defaults.base().edition = Some(Spanned::dummy(edition.into())).into(); |
But also... this is quite confusing, why do we need to Spanned everything?
RalfJung
reviewed
Jan 25, 2024
| @@ -66,8 +67,6 @@ fn test_config(target: &str, path: &str, mode: Mode, with_dependencies: bool) -> | |||
| } | |||
| } | |||
| program.args.push("-Zui-testing".into()); | |||
| program.args.push("--target".into()); | |||
| program.args.push(target.into()); | |||
There was a problem hiding this comment.
From the CI errors, removing --target doesn't seem to be right.
There was a problem hiding this comment.
yea ^^ looks like it
|
@rustbot author |
rustbot
added
the
S-waiting-on-author
oli-obk
force-pushed
the
ui_test_bump
branch
from
111ec7c to
fef6736
Compare
|
☔ The latest upstream changes (presumably #3314) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@oli-obk what's the plan with this PR? Is ui_test 0.23 ready to be used by Miri? |
|
still working on this now and then, keeping it open is not useful |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.