Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement wcslen #3474

Merged
merged 1 commit into from
May 6, 2024
Merged

Implement wcslen #3474

merged 1 commit into from
May 6, 2024

Conversation

tyilo
Copy link
Contributor

@tyilo tyilo commented Apr 16, 2024

No description provided.

src/helpers.rs Outdated Show resolved Hide resolved
src/helpers.rs Outdated Show resolved Hide resolved
@RalfJung
Copy link
Member

RalfJung commented Apr 18, 2024

@rustbot author
(use @rustbot ready when the PR is ready for review again)

@rustbot rustbot added the S-waiting-on-author Status: Waiting for the PR author to address review comments label Apr 18, 2024
src/helpers.rs Outdated Show resolved Hide resolved
src/helpers.rs Outdated Show resolved Hide resolved
@rustbot
Copy link
Collaborator

rustbot commented Apr 18, 2024

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits:

@tyilo tyilo force-pushed the wcslen branch 2 times, most recently from bcc23f8 to 70ab436 Compare May 3, 2024 11:18
@tyilo
Copy link
Contributor Author

tyilo commented May 3, 2024

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Waiting for a review to complete and removed S-waiting-on-author Status: Waiting for the PR author to address review comments labels May 3, 2024
Copy link
Member

@RalfJung RalfJung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We're entering the nit-picking stage of the review process. :)

@rustbot author

src/helpers.rs Show resolved Hide resolved
src/helpers.rs Outdated Show resolved Hide resolved
src/helpers.rs Show resolved Hide resolved
@rustbot rustbot added S-waiting-on-author Status: Waiting for the PR author to address review comments and removed S-waiting-on-review Status: Waiting for a review to complete labels May 3, 2024
@RalfJung
Copy link
Member

RalfJung commented May 6, 2024

Thanks, looks good! Please squash the commits.

@tyilo
Copy link
Contributor Author

tyilo commented May 6, 2024

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Waiting for a review to complete and removed S-waiting-on-author Status: Waiting for the PR author to address review comments labels May 6, 2024
@RalfJung
Copy link
Member

RalfJung commented May 6, 2024 via email

@RalfJung
Copy link
Member

RalfJung commented May 6, 2024 via email

@bors
Copy link
Contributor

bors commented May 6, 2024

📌 Commit 4de677f has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 6, 2024

⌛ Testing commit 4de677f with merge edcdce0...

@bors
Copy link
Contributor

bors commented May 6, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing edcdce0 to master...

@bors bors merged commit edcdce0 into rust-lang:master May 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Waiting for a review to complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants