Don't print unnecessary sysroot messages #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saethlin
force-pushed
the
quiet-when-no-change
branch
2 times, most recently
from
56e8ade to
616f485
Compare
RalfJung
reviewed
May 12, 2024
cargo-miri/src/setup.rs
Outdated
| } | ||
| write!(msg, "...").unwrap(); | ||
| if only_setup { | ||
| let mut msg = String::new(); |
There was a problem hiding this comment.
This is only needed inside the closure, it seems? Does it have to be computed outside?
There was a problem hiding this comment.
Constructing the message inside just requires giving the hook a lifetime that's not 'static inside `rustc-build-sysroot.
RalfJung
reviewed
May 12, 2024
saethlin
force-pushed
the
quiet-when-no-change
branch
2 times, most recently
from
5191888 to
d574828
Compare
|
Ah, fmt. |
|
I published a new rustc-build-sysroot, can you update the PR? |
saethlin
force-pushed
the
quiet-when-no-change
branch
from
d574828 to
a18a0f8
Compare
|
LGTM, thanks! |
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when running
cargo miri setup, we always print that a sysroot is being prepared, even if we just bail out of building after checking the hash. So that message is wrong; we didn't actually prepare a sysroot.We also always print the preparing message for
cargo miri run, even if no sysroot is prepared.With this PR,
cargo miri runprints no sysroot messages when an existing one is reused, and when a redundantcargo miri setupis requested, we print: