Call rustc_driver::main() for MIRI_BE_RUSTC=host #4731
+23
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we don't need a special case in MiriBeRustCompilerCalls.
Collaborator
|
Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two. |
RalfJung
requested changes
Nov 28, 2025
src/bin/miri.rs
Outdated
| // builds, but we are setting `-Zalways-encode-mir` which avoids those issues. | ||
| let _ = tcx.collect_and_partition_mono_items(()); | ||
| } | ||
| // cargo-miri has patched the compiler flags to make these into check-only builds, |
Member
There was a problem hiding this comment.
That's not even correct any more, is it? You removed that flag patching in #4648.
Member
Author
There was a problem hiding this comment.
The call is still necessary here as DummyCodegenBackend doesn't have it. I will update the comment though.
rustbot
added
S-waiting-on-author
Co-Authored-By: Ralf Jung <post@ralfj.de>
Member
|
That's annoying that we can't use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we don't need a special case in
MiriBeRustCompilerCalls.