Add a validity testcase for uninhabited variants #4805
Conversation
|
Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two. |
meithecatte
force-pushed
the
uninhabited-enum-validity
branch
from
7a2c7c7 to
df5113a
Compare
|
|
||
| let val = 1u32; | ||
| let ptr = (&raw const val).cast::<E>(); | ||
| unsafe { ptr.read() }; //~ ERROR: encountered an uninhabited enum variant |
There was a problem hiding this comment.
A simple transmute from 1u32 should have the same result, right? That would even take care of the size check.
There was a problem hiding this comment.
I'm not sure, I feel like you'd have a better understanding of what would happen here. Should I change it over to a transmute?
There was a problem hiding this comment.
Yeah, I think that would make this easier to understand.
Yeah, we probably mostly test this via const-eval tests... but can't hurt to also have a Miri test for this. |
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
3 participants
Found this testcase in a random unmerged branch of mine. Looks like I wrote it as part of my work on rust-lang/rust#138961, and then forgot to submit it when plans wrt the scope of that PR have changed.
I have double checked by grepping for the error message and it looks like we still don't have any similar tests in miri.