Use repr(packed) If struct requires explicit alignment of 1.
#1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @fitzgen |
fitzgen
approved these changes
Oct 11, 2017
| } else { | ||
| let ty = helpers::blob(Layout::new(0, layout.align)); | ||
| fields.push(quote! { | ||
| pub __bindgen_align: #ty , |
There was a problem hiding this comment.
This will only work to increase alignment, right? So what if we are decreasing alignment (but not all the way to 1)? I guess that requires #pragma packed or __attribute__((aligned(..))) which we don't fully support yet.
There was a problem hiding this comment.
Yep. If one would try to decrease alignment it would lead to layout test failure... just as it is now.
| #( #attributes )* | ||
| pub struct #canonical_ident | ||
| } | ||
| }; |
There was a problem hiding this comment.
This whole chunk is just code motion right?
|
Thanks as always, @pepyakin ! @bors-servo r+ |
|
📌 Commit 746c743 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 11, 2017
Use `repr(packed)` If struct requires explicit alignment of 1. Fixes #1034
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1034