Correctly handle __attribute__((noreturn)) in function arguments #2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remexre
force-pushed
the
fix-noreturn-on-arguments
branch
from
fb72abf to
7ef6f9d
Compare
remexre
force-pushed
the
fix-noreturn-on-arguments
branch
from
7ef6f9d to
0529110
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2715.
I have not been able to find a way to get at this information directly through the C API of libclang 9, so instead this patch just checks how deeply nested in parentheses the
__attribute__((noreturn))qualifier is.