Add test for quoted Env variables passed with BINDGEN_EXTRA_CLANG_ARGS. #2727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the test was too broad and just tested for existence of the variable. With this test we can ensure that quoting was indeed managed.
Context: I don't know if it's mandatory to check this kind of shell quoting detail, but wandering the code due to the shlex advisory I found this case not covered so I submit a patch!
It's used here:
Edited: has some not commited stuff in the rg cmd