Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generated constants: f64::INFINITY & f64::NEG_ INFINITY #2854

Merged
merged 13 commits into from
Jul 2, 2024
Merged

Fix generated constants: f64::INFINITY & f64::NEG_ INFINITY #2854

merged 13 commits into from
Jul 2, 2024

Conversation

gabiganam
Copy link
Contributor

eifrah-aws
eifrah-aws suggested changes Jun 25, 2024
View reviewed changes
bindgen/codegen/helpers.rs Outdated Show resolved Hide resolved
madsmtm
madsmtm reviewed Jun 25, 2024
View reviewed changes
Copy link

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure of Bindgen's MSRV policy for generated crates, but these constants require at least Rust 1.43.

@pvdrz
Copy link
Contributor

pvdrz commented Jun 25, 2024

I'm not sure of Bindgen's MSRV policy for generated crates, but these constants require at least Rust 1.43.

If that's the case, there should be a new variant in RustTarget representing 1.43 and this change should be gated behind a feature that enables if the target version is larger or equal than 1.43

@gabiganam
Copy link
Contributor Author

I'm not sure of Bindgen's MSRV policy for generated crates, but these constants require at least Rust 1.43.

If that's the case, there should be a new variant in RustTarget representing 1.43 and this change should be gated behind a feature that enables if the target version is larger or equal than 1.43

Updated the PR, hope this is what you meant.

@gabiganam gabiganam requested a review from madsmtm June 27, 2024 05:45
@madsmtm
Copy link

madsmtm commented Jun 27, 2024

@gabiganam requested a review from @madsmtm

Sorry, I'm the wrong person to ask for this, I'm not a maintainer here.

pvdrz
pvdrz requested changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@pvdrz pvdrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Could you please add this change to the changelog?

@gabiganam gabiganam requested a review from pvdrz June 30, 2024 07:55
@pvdrz pvdrz added this pull request to the merge queue Jul 2, 2024
Merged via the queue into rust-lang:main with commit 99ae2d3 Jul 2, 2024
33 checks passed
@gabiganam gabiganam deleted the patch-1 branch July 2, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eifrah-aws eifrah-aws eifrah-aws requested changes

@pvdrz pvdrz pvdrz approved these changes

@madsmtm madsmtm Awaiting requested review from madsmtm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabiganam @pvdrz @madsmtm @eifrah-aws