-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump most dependencies without change to MSRV #3009
Conversation
0152d70
to
2e6cac3
Compare
ada68b2
to
487e794
Compare
I don't think we should raise the msrv so hastily. Does any of these dependency bumps have any critical update or something? |
Not to my knowledge. 1.74 was released over a year ago on 16 November, 2023. What range of Rust versions should the latest bindgen maintain? Note that most people who may want an older compiler could simply stick to the older bindgen until they need new functionality - by which time even more time would pass after 1.74. In the mean time, I could of course update just some of the non-msrv-affecting dependencies |
c40cc51
to
612cbb8
Compare
One possible policy is picking something that major distributions are carrying. For instance, current Debian Stable (bookworm) has 1.63.0 and trixie ideally will get 1.85.0 (i.e. the very latest by the time it releases). Currently they are at 1.82.0 already (i.e. the very latest at the time of writing). Perhaps following them between releases is too slow for |
734993a
to
c775a55
Compare
I did a few trials - updating just the non-msrv affecting dependencies here |
This is an excellent question. To be honest, we don't have enough visibility to know which versions of Rust are used to compile bindgen.
Yes, however there have been instances in the past where people require a specific bugfix for an older version of bindgen just because the fix was added on a newer version with a higher msrv. Keeping a lower msrv makes this less likely.
Yes, I think this is a sensible option specially since debian is widely used as the reference point for a reasonable msrv. (@emilio what do you think? would it be reasonable to set this policy of matching the latest debian stable rust version with our msrv?) |
Bumps all the dependencies with
Due to MSRV change for the env_log, I kept it back