Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump most dependencies without change to MSRV #3009

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Nov 30, 2024

Bumps all the dependencies with

cargo +nightly -Z unstable-options update --breaking
cargo update

Due to MSRV change for the env_log, I kept it back

@nyurik nyurik force-pushed the bump-deps branch 4 times, most recently from 0152d70 to 2e6cac3 Compare November 30, 2024 20:28
@nyurik nyurik changed the title Bump all dependencies Bump all dependencies, bump MSRV to 1.74.1 Nov 30, 2024
@nyurik nyurik force-pushed the bump-deps branch 2 times, most recently from ada68b2 to 487e794 Compare December 1, 2024 04:50
@pvdrz
Copy link
Contributor

pvdrz commented Dec 1, 2024

I don't think we should raise the msrv so hastily. Does any of these dependency bumps have any critical update or something?

@nyurik
Copy link
Contributor Author

nyurik commented Dec 1, 2024

Not to my knowledge. 1.74 was released over a year ago on 16 November, 2023. What range of Rust versions should the latest bindgen maintain? Note that most people who may want an older compiler could simply stick to the older bindgen until they need new functionality - by which time even more time would pass after 1.74.

In the mean time, I could of course update just some of the non-msrv-affecting dependencies

@nyurik nyurik changed the title Bump all dependencies, bump MSRV to 1.74.1 Bump most dependencies without change to MSRV Dec 1, 2024
@nyurik nyurik force-pushed the bump-deps branch 2 times, most recently from c40cc51 to 612cbb8 Compare December 1, 2024 15:55
@ojeda
Copy link
Contributor

ojeda commented Dec 1, 2024

One possible policy is picking something that major distributions are carrying.

For instance, current Debian Stable (bookworm) has 1.63.0 and trixie ideally will get 1.85.0 (i.e. the very latest by the time it releases). Currently they are at 1.82.0 already (i.e. the very latest at the time of writing).

Perhaps following them between releases is too slow for bindgen, but nevertheless whatever Debian picks is usually good to take into account, at least for a while.

@nyurik nyurik force-pushed the bump-deps branch 2 times, most recently from 734993a to c775a55 Compare December 1, 2024 16:02
@nyurik
Copy link
Contributor Author

nyurik commented Dec 1, 2024

I did a few trials - updating just the non-msrv affecting dependencies here

@pvdrz
Copy link
Contributor

pvdrz commented Dec 1, 2024

What range of Rust versions should the latest bindgen maintain?

This is an excellent question. To be honest, we don't have enough visibility to know which versions of Rust are used to compile bindgen.

Note that most people who may want an older compiler could simply stick to the older bindgen until they need new functionality - by which time even more time would pass after 1.74.

Yes, however there have been instances in the past where people require a specific bugfix for an older version of bindgen just because the fix was added on a newer version with a higher msrv. Keeping a lower msrv makes this less likely.

One possible policy is picking something that major distributions are carrying.

For instance, current Debian Stable (bookworm) has 1.63.0 and trixie ideally will get 1.85.0 (i.e. the very latest by the time it releases). Currently they are at 1.82.0 already (i.e. the very latest at the time of writing).

Yes, I think this is a sensible option specially since debian is widely used as the reference point for a reasonable msrv. (@emilio what do you think? would it be reasonable to set this policy of matching the latest debian stable rust version with our msrv?)

@pvdrz pvdrz added this pull request to the merge queue Dec 1, 2024
Merged via the queue into rust-lang:main with commit 6bb890b Dec 1, 2024
28 checks passed
@nyurik nyurik deleted the bump-deps branch December 1, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants