Move clippy::module_name_repetitions to restriction (from pedantic)

[xFrednet]

Rational:

• Too pedantic IMO, I use #[warn(pedantic)] in my personal projects, but then always allow this lint. The fact that we had a few #[expect(clippy::module_name_repetitions)] also underlines this point IMO
• STD doesn't do this either. Examples:
  • std::vec::Vec
  • std::collections::vec_deque::VecDequeue
• Most commonly ignored lints on crates.io #7666 commonly ignored

---

changelog: Move [module_name_repetitions] to restriction (from pedantic)
#13541

[rustbot]

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[blyxyas]

I agree of the category change and approve, but just in case, is there any FCP-like process for moving lints between categories? I searched on Zulip and coulnd't find anything =^w^=

[kpreid]

STD doesn't do this either. Examples:

• std::vec::Vec
• std::collections::vec_deque::VecDequeue

It's not documented, but the lint specifically allows this case, and only lints prefixes and suffixes:

https://github.com/rust-lang/rust/blob/8f8bee4f60d9d3769f75c70d558c27a95761c554/src/tools/clippy/clippy_lints/src/item_name_repetitions.rs#L407-L408

I don't mean to object to this change, only that this specific argument for it is not correct.

[xFrednet]

is there any FCP-like process for moving lints between categories?

There hasn't been one in the past. If you want you can create an FCP. I'd do that if I was unsure about such a change

[blyxyas]

LGTM, thanks! ❤️

@bors r+

[bors]

📌 Commit 8b075fc has been approved by blyxyas

It is now in the queue for this repository.

[bors]

⌛ Testing commit 8b075fc with merge 43e99e5...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing 43e99e5 to master...