Skip to content

Use extend when creating the lint pass constructors #15994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use extend when creating the lint pass constructors #15994

wants to merge 3 commits into from

Conversation

@Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Oct 31, 2025 •
edited by rustbot
Loading

Alternative to part of #14509.

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 31, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2025

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@llogiq
Copy link
Contributor

llogiq commented Oct 31, 2025

@blyxyas what do you think? The approach seems to offer us optimal sizing (because we know the array length up front) and good perf.

@rustbot
Copy link
Collaborator

rustbot commented Nov 2, 2025

☔ The latest upstream changes (possibly e121ab8) made this pull request unmergeable. Please resolve the merge conflicts.

blyxyas
blyxyas approved these changes Nov 3, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I haven't benchmarked it, but I've never heard of a conversion from Vec to [T; N] that caused a performance regression.

View changes since this review

clippy_dev/src/new_lint.rs
format!("Box::new(move |{ctor_arg}| Box::new({module_name}::{camel_name}::new(conf))),\n ",)
} else {
format!("store.register_{lint_pass}_pass(|{ctor_arg}| Box::new({module_name}::{camel_name}));\n ",)
format!("Box::new(|{ctor_arg}| Box::new({module_name}::{camel_name})),\n ",)
Copy link
Member

@blyxyas blyxyas Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why those spaces are there? (After \n)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blyxyas blyxyas blyxyas approved these changes

Assignees

@llogiq llogiq

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Jarcho @rustbot @llogiq @blyxyas