Cancel tokens and abort tasks on drop #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`JoinSet`s already abort all their tasks when the set is dropped, so nothing to worry about there. Blocking tasks aren't really abortable, so I didn't change those.
We'd previously done this for one specific usage via the `CancelOnDrop` wrapper. This works for the more complicated case where we need to continue to clone the token. Simpler cases can use the `DropGuard` directly.
shepmaster
force-pushed
the
careful-dropping
branch
from
2dcb03b to
036f2b8
Compare
Narrator: It did not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a client disconnects, Axum drops our future. Any tasks we've spawned need to be properly notified to also exit. Enhance tasks to be aborted and cancellation tokens to be triggered when dropped.
I hope that this helps clear up some of the cases where the playground thinks that a container is still running after it has exited.