Do not mention `-Zmacro-backtrace` for std macros that are a wrapper around a compiler intrinsic #148718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

estebank wants to merge 1 commit into rust-lang:main from estebank:macro-spans

Contributor

estebank commented Nov 8, 2025

No description provided.

Collaborator

rustbot commented Nov 8, 2025

The Miri subtree was changed

cc @rust-lang/miri

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

rustbot added S-waiting-on-review T-compiler labels

rustbot assigned SparrowLii

Collaborator

rustbot commented Nov 8, 2025

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

This comment has been minimized.

Sign in to view

estebank force-pushed the macro-spans branch from fc32dee to ef13f17 Compare

November 10, 2025 17:49

Collaborator

rustbot commented Nov 10, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

rustbot added the T-clippy label

This comment has been minimized.

Sign in to view

estebank force-pushed the macro-spans branch from ef13f17 to b5121c3 Compare

December 8, 2025 23:35

Collaborator

rustbot commented Dec 8, 2025

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

This comment has been minimized.

Sign in to view

estebank force-pushed the macro-spans branch from b5121c3 to 89a3362 Compare

December 9, 2025 01:03

This comment has been minimized.

Sign in to view

estebank force-pushed the macro-spans branch from 89a3362 to 7f6fab8 Compare

December 9, 2025 16:39

This comment has been minimized.

Sign in to view


          Do not mention -Zmacro-backtrace for std macros that are a wrapper …

…around a compiler intrinsic

estebank force-pushed the macro-spans branch from 7f6fab8 to 9166315 Compare

December 9, 2025 23:37

Collaborator

bors commented Dec 15, 2025

☔ The latest upstream changes (presumably #149999) made this pull request unmergeable. Please resolve the merge conflicts.

Contributor

apiraino commented Jan 22, 2026 •

edited

Loading

r? compiler

rustbot assigned nnethercote and unassigned SparrowLii

rust-lang deleted a comment from rustbot

nnethercote approved these changes

View reviewed changes

compiler/rustc_expand/src/base.rs

    
                  /// Should debuginfo for the macro be collapsed to the outermost expansion site (in other

                  /// words, was the macro definition annotated with `#[collapse_debuginfo]`)?

                  pub collapse_debuginfo: bool,

                  pub hide_backtrace: bool,

Contributor

nnethercote Jan 23, 2026

A comment on this field would be good.

Contributor

nnethercote commented Jan 23, 2026

Nice change! Good to see this useless verbiage gone. r=me once the nit above is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review T-clippy T-compiler