Skip to content

Match <OsString as Debug>::fmt to that of str #148798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Match <OsString as Debug>::fmt to that of str #148798

wants to merge 2 commits into from
+25 −55

Conversation

@tamird
Copy link
Contributor

@tamird tamird commented Nov 10, 2025 •
edited by rustbot
Loading

Fixes #114583.

@tamird
Match <OsString as Debug>::fmt to that of str
2da23b5 
819247f changed <str as Debug>::fmt such that it does not escape single
quotes, but neglected to apply the same choice to OsString. This commit
does that.
@tamird
Remove <os::Vars as Debug> workaround
1b52275
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 10, 2025

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tamird tamird mentioned this pull request Nov 10, 2025
Open
@joboet joboet added the I-libs-nominated Nominated for discussion during a libs team meeting. label Nov 11, 2025
@tamird
Copy link
Contributor Author

tamird commented Nov 13, 2025

r? @Amanieu (approved related PR #114132)

@rustbot rustbot assigned Amanieu and unassigned ChrisDenton Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Amanieu Amanieu

Labels

I-libs-nominated Nominated for discussion during a libs team meeting. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

OsString Debug implementation prints escaped single quotes

5 participants

@tamird @rustbot @Amanieu @ChrisDenton @joboet