Skip to content

Don't report link-self-contained not being supported if it's turned off. #148804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't report link-self-contained not being supported if it's turned off. #148804

wants to merge 1 commit into from
+1 −1

Conversation

@yshui
Copy link
Contributor

@yshui yshui commented Nov 10, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Nov 10, 2025

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 10, 2025

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

wesleywiser
wesleywiser reviewed Nov 10, 2025
View reviewed changes
Copy link
Member

@wesleywiser wesleywiser left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, can we get a test added that covers showing and hiding this error message?

View changes since this review

@wesleywiser wesleywiser added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2025
@petrochenkov petrochenkov self-assigned this Nov 11, 2025
@petrochenkov
Copy link
Contributor

petrochenkov commented Nov 11, 2025

What is the motivation?
This is a "defensive" error that is reported while design and implementation of the feature is incomplete.
E.g. currently, IIRC, link-self-contained=false will not make shipped rust-lld unavailable on many targets, which it should ideally do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleywiser wesleywiser wesleywiser left review comments

Assignees

@wesleywiser wesleywiser

@petrochenkov petrochenkov

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yshui @rustbot @petrochenkov @wesleywiser