Move LTO to OngoingCodegen::join #149209
Merged
Move LTO to OngoingCodegen::join #149209
+326
−179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
cc @davidtwco, @compiler-errors, @TaKO8Ki Some changes occurred in compiler/rustc_codegen_gcc |
rustbot
added
A-LLVM
Collaborator
bjorn3
added
the
S-blocked
10 tasks
This comment has been minimized.
This comment has been minimized.
bjorn3
force-pushed
the
lto_refactors8
branch
from
8a1ac81 to
a80400f
Compare
bjorn3
force-pushed
the
lto_refactors8
branch
from
a80400f to
b13bb4b
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
bjorn3
removed
the
S-blocked
Member
Author
|
Gentle ping @jackh726 |
Member
|
@bors r+ sorry for the delay |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 21, 2026
Rollup of 4 pull requests Successful merges: - #148637 (Replace `#[rustc_do_not_implement_via_object]` with `#[rustc_dyn_incompatible_trait]`) - #149209 (Move LTO to OngoingCodegen::join) - #151402 (Simplify lookup of `DepKind` names in duplicate dep node check) - #151437 (Roll bootstrap reviewers for `src/tools/build-manifest`) r? @ghost
rust-timer
added a commit
that referenced
this pull request
Jan 21, 2026
Rollup merge of #149209 - lto_refactors8, r=jackh726 Move LTO to OngoingCodegen::join This will make it easier to in the future move all this code to link_binary. Follow up to #147810 Part of rust-lang/compiler-team#908
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to in the future move all this code to link_binary.
Follow up to #147810
Part of rust-lang/compiler-team#908