Draft
Conversation
This comment has been minimized.
This comment has been minimized.
jyn514
reviewed
Feb 5, 2026
cb9b84c to
cd83e12
Compare
Contributor
Author
|
Initial implementation completed. I plan to add more tests and check whether features in rustc are reported as unused correctly or not. |
jyn514
reviewed
Feb 5, 2026
This comment has been minimized.
This comment has been minimized.
cd83e12 to
2945856
Compare
This comment has been minimized.
This comment has been minimized.
2945856 to
36c0a20
Compare
This comment has been minimized.
This comment has been minimized.
36c0a20 to
2ddaf82
Compare
This comment has been minimized.
This comment has been minimized.
2ddaf82 to
fb08c95
Compare
This comment has been minimized.
This comment has been minimized.
fb08c95 to
38aefe4
Compare
This comment has been minimized.
This comment has been minimized.
38aefe4 to
0cda8d4
Compare
This comment has been minimized.
This comment has been minimized.
0cda8d4 to
2d2577f
Compare
This comment has been minimized.
This comment has been minimized.
2d2577f to
b67632e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
a940d65 to
435090a
Compare
4ba23c6 to
acb3115
Compare
This comment has been minimized.
This comment has been minimized.
acb3115 to
1875ae8
Compare
This comment has been minimized.
This comment has been minimized.
1875ae8 to
382a5fe
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Some incremental tests failed because query features will be always dirty. And some of these have expired with current implementation. For now, I just update them to fit the new result directly. Expired ones should be removed if current implementation is accepted finally. |
This comment has been minimized.
This comment has been minimized.
5551df6 to
b807143
Compare
b807143 to
9b6aa0d
Compare
This comment has been minimized.
This comment has been minimized.
9b6aa0d to
2d0bb85
Compare
This comment has been minimized.
This comment has been minimized.
2d0bb85 to
8fc6deb
Compare
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 13, 2026
…atures, r=nadrieril,jdonszelmann Remove unused features Detected by rust-lang#152164. ~~Only allow `unused_features` if there are complex platform-specific features enabled.~~
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 13, 2026
…atures, r=nadrieril,jdonszelmann Remove unused features Detected by rust-lang#152164. ~~Only allow `unused_features` if there are complex platform-specific features enabled.~~
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 13, 2026
…atures, r=nadrieril,jdonszelmann Remove unused features Detected by rust-lang#152164. ~~Only allow `unused_features` if there are complex platform-specific features enabled.~~
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 13, 2026
…atures, r=nadrieril,jdonszelmann Remove unused features Detected by rust-lang#152164. ~~Only allow `unused_features` if there are complex platform-specific features enabled.~~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44232
Fixes #151752