-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
Fix const normalization for generic const items with trait assoc consts #152278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+25
−3
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
tests/ui/generic-const-items/type-const-nested-assoc-const.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| //@ check-pass | ||
|
|
||
| #![feature(generic_const_items, min_generic_const_args)] | ||
| #![allow(incomplete_features)] | ||
|
|
||
| type const CT<T: ?Sized>: usize = { <T as Trait>::N }; | ||
|
|
||
| trait Trait { | ||
| type const N: usize; | ||
| } | ||
|
|
||
| impl<T: ?Sized> Trait for T { | ||
| type const N:usize = 0; | ||
| } | ||
|
|
||
| fn f(_x: [(); CT::<()>]) {} | ||
|
|
||
| fn main() {} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect this to just be
if term.has_aliases()and I don't understand why it isn't. Can you try changing it to that and see if anything breaks?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
term.has_aliases()is not a proper solution (though I didn't know that API). Actually it caused a SEGV during stage1 lib building:output (extracted)
HAS_ALIASincludesHAS_TY_OPAQUE, and opaque types are not normalized outside ofTypingMode::PostAnalysis, so theres!=term.to_term(tcx)condition keeps passing and the recursion never terminates.I also found
needs_normalization(), which excludesHAS_TY_OPAQUEdepending on the typing mode, but it still includesHAS_TY_PROJECTIONand others, which similarly caused a stack overflow. Since projection types are already handled directly bytry_fold_ty, the re-normalization here should only needHAS_CT_PROJECTIONand theFreeTy/FreeConstcases (asnormalize_canonicalized_free_alias()only unwraps one layer) I think.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks :3