Skip to content

Port rust_nonnull_optimization_guaranteed and rustc_do_not_const_check to the new attribute parser#152296

Open
jdonszelmann wants to merge 2 commits intorust-lang:mainfrom
jdonszelmann:port-rust-nonnull-guaranteed
Open

Port rust_nonnull_optimization_guaranteed and rustc_do_not_const_check to the new attribute parser#152296
jdonszelmann wants to merge 2 commits intorust-lang:mainfrom
jdonszelmann:port-rust-nonnull-guaranteed

Conversation

@jdonszelmann
Copy link
Contributor

r? @JonathanBrouwer another two of them :)

@rustbot
Copy link
Collaborator

rustbot commented Feb 7, 2026

Some changes occurred in compiler/rustc_hir/src/attrs

cc @JonathanBrouwer

Some changes occurred to constck

cc @fee1-dead

Some changes occurred in compiler/rustc_attr_parsing

cc @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @JonathanBrouwer

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 7, 2026
@jdonszelmann jdonszelmann changed the title Port rust nonnull guaranteed Port rust_nonnull_optimization_guaranteed and rustc_do_not_const_check to the new attribute parser Feb 7, 2026
@JonathanBrouwer
Copy link
Contributor

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 7, 2026

📌 Commit 8c3514e has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2026
@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 7, 2026
@rust-bors

This comment has been minimized.

@jdonszelmann jdonszelmann force-pushed the port-rust-nonnull-guaranteed branch from 8c3514e to 513a578 Compare February 8, 2026 21:27
@rustbot

This comment has been minimized.

@jdonszelmann
Copy link
Contributor Author

@bors r=jonathanbrouwer

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 8, 2026

📌 Commit 513a578 has been approved by jonathanbrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 8, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 8, 2026
@jdonszelmann
Copy link
Contributor Author

@bors r-

@jdonszelmann jdonszelmann force-pushed the port-rust-nonnull-guaranteed branch from 513a578 to 26ee8ee Compare February 9, 2026 09:22
@rustbot

This comment has been minimized.

@jdonszelmann
Copy link
Contributor Author

@bors r=jonathanbrouwer

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 9, 2026

📌 Commit 26ee8ee has been approved by jonathanbrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 9, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 9, 2026
…ranteed, r=jonathanbrouwer

Port `rust_nonnull_optimization_guaranteed` and `rustc_do_not_const_check` to the new attribute parser

r? @JonathanBrouwer another two of them :)
@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 9, 2026
@rust-bors

This comment has been minimized.

@jdonszelmann
Copy link
Contributor Author

@bors r-

@rust-log-analyzer

This comment has been minimized.

@jdonszelmann jdonszelmann force-pushed the port-rust-nonnull-guaranteed branch from 26ee8ee to 9fee1a2 Compare February 9, 2026 09:53
@rustbot

This comment has been minimized.

@rust-bors

This comment has been minimized.

@jdonszelmann jdonszelmann force-pushed the port-rust-nonnull-guaranteed branch from 9fee1a2 to 86200bf Compare February 13, 2026 09:47
@rustbot
Copy link
Collaborator

rustbot commented Feb 13, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@jdonszelmann
Copy link
Contributor Author

@bors r=jonathanbrouwer

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 13, 2026

📌 Commit 86200bf has been approved by jonathanbrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 13, 2026
rust-bors bot pushed a commit that referenced this pull request Feb 13, 2026
…uwer

Rollup of 14 pull requests

Successful merges:

 - #152323 (Fix ICE in borrowck when recovering `fn_sig` for `-> _`)
 - #152469 (Remove unused features)
 - #152515 (Extract `DepKindVTable` constructors to their own module)
 - #152555 (Port `#[rustc_diagnostic_item]` to the new attribute parsers)
 - #152218 (Report unconstrained region in hidden types lazily)
 - #152356 (Improve the `inline_fluent!` macro)
 - #152392 (Fix ICE in supertrait_vtable_slot when supertrait has missing generics)
 - #152407 (Add regression test for type_const with unit struct ctor under mGCA)
 - #152440 (Fix typos and grammar in compiler and build documentation)
 - #152536 (bootstrap: add explicit UTF-8 encoding to text-mode open() calls)
 - #152554 (Remove `deprecated_safe` and its corresponding feature gate)
 - #152556 (doc: move riscv64a23-unknown-linux-gnu to tier 2)
 - #152563 (Replace "bug" with "issue" in triagebot ping messages)
 - #152565 (fix missleading error for tuple ctor)

Failed merges:

 - #152512 (core: Implement feature `float_exact_integer_constants`)
 - #152296 (Port `rust_nonnull_optimization_guaranteed` and `rustc_do_not_const_check` to the new attribute parser)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants