Rollup of 9 pull requests#152639
Conversation
(cherry picked from commit b901497)
Co-authored-by: lcnr <rust@lcnr.de>
Unix Domain Socket support has only been added to Windows since Windows 10 Insider Preview Build 17063. Thus, it has no chance of ever being supported under Windows 7, making current tests fail. This therefore adds the necessary in order to make the tests dynamically skip when run under Windows 7, 8, and early 10, as it does not trigger linker errors. Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>
…mGCA Using a struct constructor (DefKind::Ctor(Struct, Const)) as an array repeat count with `#![feature(min_generic_const_args)]` used to trigger an ICE in const alias normalization. Add a regression test to ensure the compiler produces a proper type error instead of panicking.
…, r=lcnr diagnostics: add note when param-env shadows global impl This PR adds a diagnostics note when param-env shadows global impl as discussed in rust-lang#149910 It adds a note explaining that the definition is hidden by the generic bound. r?lcnr
…imulacrum implement `carryless_mul` tracking issue: rust-lang#152080 ACP: rust-lang/libs-team#738 This defers to LLVM's `llvm.clmul` when available, and otherwise falls back to a method from the `polyval` crate ([link](https://github.com/RustCrypto/universal-hashes/blob/master/polyval/src/field_element/soft/soft64.rs)). Some things are missing, which I think we can defer: - the ACP has some discussion about additional methods, but I'm not sure exactly what is wanted or how to implement it efficiently - the SIMD intrinsic is not yet `const` (I think I ran into a bootstrapping issue). That is fine for now, I think in `stdarch` we can't really use this intrinsic at the moment, we'd only want the scalar version to replace some riscv intrinsics. - the SIMD intrinsic is not implemented for the gcc and cranelift backends. That should be reasonably straightforward once we have a const eval implementation though.
…gnostic, r=Mark-Simulacrum Improve write! and writeln! error when called without destination Fixes rust-lang#152493 Adds catch-all arms to `write!` and `writeln!` macros so that calling them without a destination (e.g., `write!("S")` instead of `write!(f, "S")`) gives a clear error instead of the cryptic "unexpected end of macro invocation" pointing at macro internals. r? @estebank
… r=Mark-Simulacrum Test(lib/win/net): Skip UDS tests when under Win7 Unix Domain Socket support has only been added to Windows since Windows 10 Insider Preview Build 17063. Thus, it has no chance of ever being supported under Windows 7, making current tests fail. This therefore adds the necessary in order to make the tests dynamically skip when run under Windows 7, 8, and early 10, as it does not trigger linker errors. cc rust-lang#150487 @roblabla @rustbot label T-libs A-io O-windows-7
…crum ci: Lock cross toolchain version and update docs This PR locks the cross-toolchain component version to avoid unexpected changes when bumping crosstool-ng, and updates the toolchain configuration in the docs to match the actual setup. try-job: dist-arm-linux-musl try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl try-job: dist-powerpc64-linux-musl try-job: dist-powerpc64le-linux-gnu try-job: dist-powerpc64le-linux-musl
…k-Simulacrum Include `library/stdarch` for `CURRENT_RUSTC_VERSION` updates Our tool `replace-version-placeholder` uses the `tidy` file walker and its directory filter, but that skips `library/stdarch` which we do need for public stability markers. This PR adds a local filter function that explicitly allows that path. The commit for 1.94 `stdarch` updates is coming from beta rust-lang#152187.
…ctor-array-len, r=BoxyUwU Add regression test for rust-lang#141738 Closes rust-lang#141738 - Add a regression test for rust-lang#141738 - Using a struct constructor (`DefKind::Ctor(Struct, Const)`) as an array repeat count with `#![feature(min_generic_const_args)]` used to ICE in const alias normalization - Fixed by rust-lang#150704, which added const constructor support for mGCA. This test covers the **error path** (struct ctor where `usize` is expected), which was not covered by the tests in rust-lang#150704
unwind/wasm: fix compile error by wrapping wasm_throw in unsafe block This fix rust-std compile error on wasm32-unknown-unknown with panic=unwind because of `#![deny(unsafe_op_in_unsafe_fn)]`
…, r=clubby789 Exchange js_lint message between bless and non-bless The message `applying suggestions` should be emitted when bless is enabled.
|
@bors r+ rollup=never p=5 |
This comment has been minimized.
This comment has been minimized.
|
📌 Perf builds for each rolled up PR:
previous master: 75b9d89c68 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 75b9d89 (parent) -> ce0bf0b (this PR) Test differencesShow 4434 test diffsStage 1
Stage 2
Additionally, 4400 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard ce0bf0b22b646bacf91f73393483f684a44848ca --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (ce0bf0b): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -8.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 0.1%, secondary -0.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.1%, secondary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 480.584s -> 479.824s (-0.16%) |
Successful merges:
carryless_mul#152132 (implementcarryless_mul)library/stdarchforCURRENT_RUSTC_VERSIONupdates #152188 (Includelibrary/stdarchforCURRENT_RUSTC_VERSIONupdates)DefKindfor const alias to resolve to: Ctor(Struct, Const) #141738)r? @ghost
Create a similar rollup