Draft
Conversation
bjorn3
added
the
S-blocked
rustbot
added
A-LLVM
13 tasks
Contributor
petrochenkov
removed
the
S-waiting-on-author
As far as I can tell it was introduced to allow fat LTO with -Clinker-plugin-lto. Later a change was made to automatically disable ThinLTO summary generation when -Clinker-plugin-lto -Clto=fat is used, so we can safely remove it.
In favor of passing a NULL ThinLTOSummaryBufferRef. And improve type improve type safety on the Rust side.
bjorn3
force-pushed
the
lto_refactors12
branch
from
26c7b6b to
58e13b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the amount of complexity around ThinLTO module buffers. It removes duplication between
ModuleBufferandThinBuffer(the latter was also used for fat LTO in some cases), clarifies when and where the ThinLTO summary is used (only for--emit thin-link-bitcode, ThinLTO performed by rustc rebuilds the summary every time). This also enables a follow up cleanup to reduce code duplication between red, green and imported codegen units.Builds on top of #152527
Part of rust-lang/compiler-team#908