Closed
Conversation
Unlike other systems, Windows requires runtime libraries to be present in `PATH` or right next to the binary. So, we copy the library next to the binary as the easier solution.
This struct was only wrapping `TyCtxt` in order to implement traits that were removed by RUST-152636. This commit also slightly simplifies the signature of `execute_job_incr`, by having it call `tcx.dep_graph.data()` internally.
The need for a `HasDepContext` impl on tuples can be avoided by passing the query vtable as part of an argument tuple instead.
Install LLVM DLL in the right place on Windows Continuation of rust-lang#151795 towards rust-lang#151774. Unlike other systems, Windows requires runtime libraries to be present in `PATH` or right next to the binary. So, we copy the library next to the binary as the easier solution. Tested building `rust-openssl` in debug and release modes, but the difference is within noise margin.
…lcnr `-Znext-solver` Remove the forced ambiguity hack from search graph As discussed in rust-lang/trait-system-refactor-initiative#257 r? lcnr
Remove `QueryCtxt` and trait `HasDepContext` - Follow-up to rust-lang#152636. - Potentially waiting on rust-lang#152703 to reduce conflicts. --- With the `QueryContext` trait removed, wrapper struct `QueryCtxt` no longer serves a purpose and can be replaced with `TyCtxt` everywhere. After that, the only obstacle to removing trait `HasDepContext` is `DepGraph::with_task`, which uses the trait to allow passing both a `TyCtxt` and a query vtable through the context argument. But we can achieve the same result by passing the vtable through the other argument instead, in a tuple alongside the query key. r? nnethercote
…enkov remove `#![allow(stable_features)]` from most tests The only remaining usages are tests that specifically deal with feature gates. This also deletes the very weird `#![feature(issue_5723_bootstrap)]`, a 13 year old "temporary fix" (rust-lang#5723).
Improve `VaList` stdlib docs tracking issue: rust-lang#44930 Some improvements to the `VaList` documentation, at least adding an example. We should link to the reference for c-variadic functions once stable. I've tried to call out explicitly that the type is meant for sending over the FFI boundary. r? workingjubilee cc @tgross35
…uillaumeGomez Update `sysinfo` version to `0.38.2` r? ghost
rustbot
added
A-CI
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
-Znext-solverRemove the forced ambiguity hack from search graph #149904 (-Znext-solverRemove the forced ambiguity hack from search graph)QueryCtxtand traitHasDepContext#152704 (RemoveQueryCtxtand traitHasDepContext)#![allow(stable_features)]from most tests #152746 (remove#![allow(stable_features)]from most tests)VaListstdlib docs #152675 (ImproveVaListstdlib docs)sysinfoversion to0.38.2#152748 (Updatesysinfoversion to0.38.2)r? @ghost
Create a similar rollup