Skip to content

refactor: move check_align to parse_alignment#153189

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
JayanAXHF:refactor/check_attrs_reftor_1
Mar 6, 2026
Merged

refactor: move check_align to parse_alignment#153189
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
JayanAXHF:refactor/check_attrs_reftor_1

Conversation

@JayanAXHF
Copy link
Member

@JayanAXHF JayanAXHF commented Feb 27, 2026 •
edited by rustbot
Loading

Part of #153101

r? @JonathanBrouwer

PS: jonathan i'm not sure about what to do with check_align now

@rustbot
Copy link
Collaborator

rustbot commented Feb 27, 2026

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 27, 2026
@JayanAXHF JayanAXHF added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-AST Area: AST labels Feb 27, 2026
JonathanBrouwer
JonathanBrouwer requested changes Feb 27, 2026
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Mar 1, 2026

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JayanAXHF
Copy link
Member Author

JayanAXHF commented Mar 1, 2026

@JonathanBrouwer I think i've finally gotten everything in order :D

@JayanAXHF JayanAXHF force-pushed the refactor/check_attrs_reftor_1 branch from a1cb53e to a026d9d Compare March 1, 2026 14:53
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Mar 1, 2026

I'll take a look sometime in the next few days :)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 1, 2026
JonathanBrouwer
JonathanBrouwer requested changes Mar 2, 2026
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2026
@JayanAXHF JayanAXHF changed the title refactor: add move check_align to parse_alignment refactor: move check_align to parse_alignment Mar 4, 2026
@JayanAXHF
Copy link
Member Author

JayanAXHF commented Mar 4, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 4, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Mar 5, 2026

@rustbot author
ci is sad :c

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2026
@JayanAXHF
Copy link
Member Author

JayanAXHF commented Mar 5, 2026 •
edited
Loading

@rustbot ready
CI is happy again :D

I also fixed the first commit's name so if its good to go then you can squash and merge from bors directly :)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 5, 2026
@JayanAXHF JayanAXHF force-pushed the refactor/check_attrs_reftor_1 branch from 0b79ab0 to 6321e44 Compare March 5, 2026 14:51
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Mar 5, 2026

@bors squash

@rust-bors

This comment has been minimized.

Sign in to view
@JayanAXHF
refactor: move check_align to parse_alignment
2093158 
* refactor: move `check_align` from check_attrs.rs to `parse_alignment`

rel: attribute parser rework
* fix: fix error messages
* test: fix test
* fix: fix invalid error message
* ops(test): Fix CI
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 5, 2026

🔨 5 commits were squashed into 2093158.

@rust-bors rust-bors bot force-pushed the refactor/check_attrs_reftor_1 branch from 6321e44 to 2093158 Compare March 5, 2026 18:46
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Mar 5, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 5, 2026

📌 Commit 2093158 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Mar 5, 2026
Open
28 tasks
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 6, 2026
@jhpratt
Rollup merge of rust-lang#153189 - JayanAXHF:refactor/check_attrs_ref…
e27f876 
…tor_1, r=JonathanBrouwer

refactor: move `check_align` to `parse_alignment`

Part of rust-lang#153101

r? @JonathanBrouwer

PS: jonathan i'm not sure about what to do with `check_align` now
@jhpratt jhpratt mentioned this pull request Mar 6, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Mar 6, 2026
@bors
Auto merge of #153467 - jhpratt:rollup-uxqJkCS, r=jhpratt
882984e 
Rollup of 7 pull requests

Successful merges:

 - #153466 (`rust-analyzer` subtree update)
 - #151280 (Fix incorrect trailing comma suggested in no_accessible_fields)
 - #152593 (Box in `ValTreeKind::Branch(Box<[I::Const]>)` changed to `List`)
 - #153189 (refactor: move `check_align` to `parse_alignment`)
 - #153230 (Roll rustfmt reviewers for in-tree rustfmt)
 - #153321 (Add high-priority ICEs to tests/crashes)
 - #153445 (Consider try blocks as block-like for overflowed expr)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 6, 2026
@JonathanBrouwer
Rollup merge of rust-lang#153189 - JayanAXHF:refactor/check_attrs_ref…
7f9e761 
…tor_1, r=JonathanBrouwer

refactor: move `check_align` to `parse_alignment`

Part of rust-lang#153101

r? @JonathanBrouwer

PS: jonathan i'm not sure about what to do with `check_align` now
@JonathanBrouwer JonathanBrouwer mentioned this pull request Mar 6, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Mar 6, 2026
@bors
Auto merge of #153490 - JonathanBrouwer:rollup-2qfRVzJ, r=JonathanBro…
a3bc38c 
…uwer

Rollup of 9 pull requests

Successful merges:

 - #153466 (`rust-analyzer` subtree update)
 - #151280 (Fix incorrect trailing comma suggested in no_accessible_fields)
 - #152593 (Box in `ValTreeKind::Branch(Box<[I::Const]>)` changed to `List`)
 - #153174 (std: add wasm64 to sync::Once and thread_parking atomics cfg guards)
 - #153189 (refactor: move `check_align` to `parse_alignment`)
 - #153230 (Roll rustfmt reviewers for in-tree rustfmt)
 - #153445 (Consider try blocks as block-like for overflowed expr)
 - #153476 (bootstrap.py: fix typo "parallle")
 - #153483 (Preserve parentheses around `Fn` trait bounds in pretty printer)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 6, 2026
@JonathanBrouwer
Rollup merge of rust-lang#153189 - JayanAXHF:refactor/check_attrs_ref…
fb6afe7 
…tor_1, r=JonathanBrouwer

refactor: move `check_align` to `parse_alignment`

Part of rust-lang#153101

r? @JonathanBrouwer

PS: jonathan i'm not sure about what to do with `check_align` now
This was referenced Mar 6, 2026
Closed
Merged
rust-bors bot pushed a commit that referenced this pull request Mar 6, 2026
@bors
Auto merge of #153507 - JonathanBrouwer:rollup-ki59UTE, r=JonathanBro…
80282b1 
…uwer

Rollup of 14 pull requests

Successful merges:

 - #153466 (`rust-analyzer` subtree update)
 - #151280 (Fix incorrect trailing comma suggested in no_accessible_fields)
 - #152593 (Box in `ValTreeKind::Branch(Box<[I::Const]>)` changed to `List`)
 - #153174 (std: add wasm64 to sync::Once and thread_parking atomics cfg guards)
 - #153485 (libcore float tests: replace macro shadowing by const-compatible macro)
 - #153495 (Fix ICE in `offset_of!` error recovery)
 - #152040 (Do not emit ConstEvaluatable goals if type-const)
 - #152741 (Suppress invalid suggestions in destructuring assignment)
 - #153189 (refactor: move `check_align` to `parse_alignment`)
 - #153230 (Roll rustfmt reviewers for in-tree rustfmt)
 - #153445 (Consider try blocks as block-like for overflowed expr)
 - #153452 (Cleanup unused diagnostic emission methods)
 - #153476 (bootstrap.py: fix typo "parallle")
 - #153483 (Preserve parentheses around `Fn` trait bounds in pretty printer)
@rust-bors rust-bors bot merged commit 56c8de6 into rust-lang:main Mar 6, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 6, 2026
rust-timer added a commit that referenced this pull request Mar 6, 2026
@rust-timer
Unrolled build for #153189
d3219ef 
Rollup merge of #153189 - JayanAXHF:refactor/check_attrs_reftor_1, r=JonathanBrouwer

refactor: move `check_align` to `parse_alignment`

Part of #153101

r? @JonathanBrouwer

PS: jonathan i'm not sure about what to do with `check_align` now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanBrouwer JonathanBrouwer Awaiting requested review from JonathanBrouwer

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

A-AST Area: AST A-attributes Area: Attributes (`#[…]`, `#![…]`) C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

4 participants

@JayanAXHF @rustbot @rust-log-analyzer @JonathanBrouwer