Fix ICEs due to incomplete typechecking on struct literals with syntax errors.#153453
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 5, 2026
Merged
Fix ICEs due to incomplete typechecking on struct literals with syntax errors.#153453rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Contributor
|
r=me once green |
fmease
approved these changes
Mar 5, 2026
Member
|
Needn't wait on CI. @bors r=fmease,estebank rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 5, 2026
…uwer Rollup of 9 pull requests Successful merges: - #153399 (constify `Vec::{into, from}_raw_parts{_in|_alloc}`) - #153436 (Use shlex instead of shell-words) - #150845 (bootstrap: minimal fix for ./x install src with build.docs = false) - #152906 (Make `const_lit_matches_ty` check literal suffixes for exact type match) - #153378 (Rename `QueryCache::iter` to `for_each`) - #153386 (Minor query cleanups) - #153422 (Add a comment explaining the 'tcx lifetime.) - #153435 (Fix obtaining def_id from unresolved segment) - #153453 (Fix ICEs due to incomplete typechecking on struct literals with syntax errors.)
rust-timer
added a commit
that referenced
this pull request
Mar 5, 2026
Rollup merge of #153453 - kpreid:fix-153388, r=fmease,estebank Fix ICEs due to incomplete typechecking on struct literals with syntax errors. Fixes #153388. Followup to #153227. Today I have learned that when we don’t emit a diagnostic *specifically from typeck*, we need to call `self.infcx.set_tainted_by_errors()` to signal that the type checking is incomplete despite the lack of error. r? fmease
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153388.
Followup to #153227.
Today I have learned that when we don’t emit a diagnostic specifically from typeck, we need to call
self.infcx.set_tainted_by_errors()to signal that the type checking is incomplete despite the lack of error.r? fmease