Fix #1737: Specify toolchain part in building and running #2659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
There was an issue raised that the toolchain explanation for building and running the compiler needed some refinement. This patch aims to remedy that by specifying what "first" and "second" refer to, and what the toolchain does. Small change to the language to specify that the stage2 toolchain is not built, and how one would build it.
Mattias-Petersson
force-pushed
the
fix-1737
branch
from
07d5532 to
e2ad700
Compare
Author
|
r? rustc-dev-guide Hello :) My first issue, wanted to start small and easy. Glad to be able to contribute to the project and hope to take on more challenging tasks in the near future! |
tshepang
reviewed
Nov 27, 2025
Comment on lines
+280
to
+282
| command listed below runs the stage1 compiler, which was built in the | ||
| steps above, with the name `stage1`. The second command runs the stage2 | ||
| compiler using the stage1 compiler. This will be needed in the future |
Member
There was a problem hiding this comment.
more correct, maybe
Suggested change
| command listed below runs the stage1 compiler, which was built in the | |
| steps above, with the name `stage1`. The second command runs the stage2 | |
| compiler using the stage1 compiler. This will be needed in the future | |
| command listed below creates the stage1 toolchain, which was built in the | |
| steps above, with the name `stage1`. The second command creates the stage2 | |
| toolchain using the stage1 compiler. This will be needed in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue raised that the toolchain explanation for building and running the compiler needed some refinement. This patch aims to remedy that by specifying what "first" and "second" refer to, and what the toolchain does. Small change to the language to specify that the stage2 toolchain is not built, and how one would build it.