Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid some string allocations #6306

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Avoid some string allocations #6306

merged 2 commits into from
Sep 3, 2024

Conversation

Rawk
Copy link
Contributor

@Rawk Rawk commented Sep 1, 2024

Avoid allocating intermediate strings in ItemizedBlock::trimmed_block_as_string and determine_operation.

ytmimi
ytmimi approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes seem reasonable and the Diff Check passed.

@ytmimi ytmimi merged commit 5d30ce6 into rust-lang:master Sep 3, 2024
26 checks passed
@Rawk Rawk deleted the avoid-string-alloc branch September 3, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytmimi ytmimi ytmimi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rawk @ytmimi @rustbot