Defer changes for zero argument functions until style_edition=2027
#6362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytmimi
force-pushed
the
update_2024_fn_return_type
branch
2 times, most recently
from
4a007a6
to
00e64f0
Compare
This was missed when the `Edition2027` variant was added.
This moves changes that were originally gated by `version=Two` to `style_edition=2027` instead of releasing them with `style_edition=2024`.
ytmimi
force-pushed
the
update_2024_fn_return_type
branch
from
00e64f0
to
268b4f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #5577 (comment), the style team didn't want to move forward with these changes for
style_edition=2024so I've kicked this down the road tostyle_edition=2027.r? @calebcartwright