Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Disable openssl for loongarch64-unknown-linux-gnu #3536

Merged
merged 1 commit into from
Nov 25, 2023
Merged

CI: Disable openssl for loongarch64-unknown-linux-gnu #3536

merged 1 commit into from
Nov 25, 2023

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Nov 17, 2023

This pull request adds vectorized AES, and no vector instructions support detecting. After rustup's openssl-src was updated to include the patch, the build failed:

crypto/aes/vpaes-loongarch64.S: Assembler messages:
crypto/aes/vpaes-loongarch64.S:24: Error: no match insn: vori.b	$vr1,$vr9,0

The good new is that openssl next bump will fix the issue. For the release of 1.27.0, this patch temporarily disables the openssl features for loongarch64-unknown-linux-gnu target. This change will be reverted after the new openssl is released.

Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, thanks!

@rami3l rami3l merged commit a602238 into rust-lang:master Nov 25, 2023
16 checks passed
@rami3l
Copy link
Member

rami3l commented Nov 27, 2023

@heiher I'm not familiar with the release process of OpenSSL, but is https://github.com/openssl/openssl/releases/tag/openssl-3.2.0 what you were waiting for?

@heiher
Copy link
Contributor Author

heiher commented Nov 27, 2023

@heiher I'm not familiar with the release process of OpenSSL, but is https://github.com/openssl/openssl/releases/tag/openssl-3.2.0 what you were waiting for?

Yeah. Thank you. It's great! Now waiting for openssl-src to be bumped to this version. After the rustup locked openssl-src is bumped, we can revert this patch.

@rami3l
Copy link
Member

rami3l commented Nov 27, 2023

Now waiting for openssl-src to be bumped to this version.

You should probably wait for alexcrichton/openssl-src-rs#217, that is.

@rami3l rami3l added this to the 1.27.0 milestone Jan 18, 2024
@rami3l rami3l mentioned this pull request Jan 29, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants