Flatten notification enums #4496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
force-pushed
the
no-dist-temp-notifications
branch
2 times, most recently
from
8e90e40 to
93451db
Compare
djc
force-pushed
the
no-dist-temp-notifications
branch
from
93451db to
37ab3c5
Compare
djc
force-pushed
the
no-dist-temp-notifications
branch
from
37ab3c5 to
4578dea
Compare
rami3l
approved these changes
Sep 23, 2025
There was a problem hiding this comment.
Many thanks! It will definitely make #4471 even clearer for @FranciscoTGouveia, so looking forward to landing it :)
| Install(n) => n.level(), | ||
| Utils(n) => n.level(), | ||
| Temp(n) => n.level(), | ||
| ChecksumValid(_) |
There was a problem hiding this comment.
The original code (that has been deleted in this PR) seems to be grouping this by notification level first and then by order of variants. Should we do the same with the merged version?
There was a problem hiding this comment.
I intend to delete most of Notification in a next PR, so I don't think there's a lot of value in style tweaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had 4 different
Notificationenums:dist::notifications::Notificationdist::temp::Notificationutils::notifications::Notificationnotifications::NotificationWhile these carried somewhat different variants (although there was some overlap as well!), the complexity of having these separate types does not seem worth it. (And in fact, the existence of the
Notificationtype itself doesn't seem all that valuable.) Merge all the variants into the top-level type.