Skip to content

Conversation

@Urgau
Copy link
Member

@Urgau Urgau commented Jan 15, 2026

This PR is a bag of small fixes and improvements for our GH comments and related endpoint, specifically it:

  1. Add license information for our embedded copy github-markdown-css
  2. Extract GitHubComments cache logic into a re-usable cache and make us of it for gh-comments and gha-logs
    • As part of this, I also fixed the pruning logic to remove the value size
  3. Add alias /issues for our GH Comment endpoint to simplify access from GitHub url
  4. Add a message about pull-requests being not yet supported
  5. Regenerate our copy of GitHub's Markdown css (as we were missing ~1yr worth of updates)
  6. Allow inline style attributes to fix CSP violations

Best reviewed commit by commit.

@Urgau Urgau requested a review from Kobzol January 15, 2026 20:00
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Urgau Urgau added this pull request to the merge queue Jan 16, 2026
Merged via the queue into rust-lang:master with commit 60c4a7a Jan 16, 2026
3 checks passed
@Urgau Urgau deleted the gh-comments-1 branch January 16, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants