Add PR support to our GitHub comments viewer #2254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
approved these changes
Jan 17, 2026
Member
There was a problem hiding this comment.
Stress tested this on http://0.0.0.0:8000/gh-comments/rust-lang/rust/pull/112049 😆 Looks awesome, great job!
Member
Author
👀 I certainly hope "1950 comments and reviews" is a stress test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for pull-request to our GitHub comments viewer.
It can be accessed at
/gh-comments/{owner}/{repo}/pull/{pr}.The support is not perfect unfortunately, we are missing the diff selection for review threads, GitHub's API only gives us the file and line number, we would have to fetch the diff our-selves.
Another thing that is not perfect is suggestions, they don't seems to be supported by(I managed to hack the generator and have something good enough)github-comments.css. I will investigate later.Otherwise the support is quite good IMO.
Requested multiple times in #triagebot > Our own GitHub issue comments viewer
Best reviewed commits by commits.
Example in image