Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fixes #319

Merged
merged 3 commits into from
Oct 15, 2023
Merged

Build fixes #319

merged 3 commits into from
Oct 15, 2023

Conversation

YuhanLiin
Copy link
Collaborator

resolves #311

@codecov-commenter
Copy link

Codecov Report

Attention: 67 lines in your changes are missing coverage. Please review.

Comparison is base (4adece5) 37.08% compared to head (87e7325) 36.60%.
Report is 3 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
- Coverage   37.08%   36.60%   -0.49%     
==========================================
  Files          94       94              
  Lines        6196     6240      +44     
==========================================
- Hits         2298     2284      -14     
- Misses       3898     3956      +58     
Files Coverage Δ
algorithms/linfa-ftrl/src/hyperparams.rs 15.38% <ø> (ø)
algorithms/linfa-ftrl/src/lib.rs 16.66% <ø> (+8.33%) ⬆️
algorithms/linfa-logistic/src/float.rs 0.00% <ø> (ø)
algorithms/linfa-logistic/src/hyperparams.rs 32.35% <ø> (-5.89%) ⬇️
src/dataset/mod.rs 33.33% <ø> (+3.70%) ⬆️
src/metrics_classification.rs 38.36% <ø> (+0.78%) ⬆️
algorithms/linfa-logistic/src/lib.rs 45.62% <47.82%> (-1.83%) ⬇️
algorithms/linfa-logistic/src/argmin_param.rs 10.95% <1.78%> (-33.49%) ⬇️

... and 65 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YuhanLiin YuhanLiin merged commit ff5d836 into rust-ml:master Oct 15, 2023
20 checks passed
@YuhanLiin YuhanLiin deleted the build-fixes branch October 15, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency version thiserror in linfa hierarchical causes problems in real world projects
2 participants